[AKS] az aks nodepool add/update: Add option Ubuntu2404 to --os-sku parameter#32509
[AKS] az aks nodepool add/update: Add option Ubuntu2404 to --os-sku parameter#32509zhoxing-ms merged 3 commits intoAzure:devfrom
az aks nodepool add/update: Add option Ubuntu2404 to --os-sku parameter#32509Conversation
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull request overview
This PR adds support for Ubuntu 24.04 LTS as a new OS SKU option for AKS node pools, allowing customers to select Ubuntu2404 when creating or updating Linux node pools.
Key Changes:
- Added
CONST_OS_SKU_UBUNTU2404constant definition - Updated parameter lists to include Ubuntu2404 for nodepool add and update operations
- Updated help documentation for the
--os-skuparameter to include Ubuntu2404 - Added test coverage for the new Ubuntu2404 OS SKU option
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/acs/_consts.py | Defines the new constant CONST_OS_SKU_UBUNTU2404 = "Ubuntu2404" |
| src/azure-cli/azure/cli/command_modules/acs/_params.py | Imports the new constant and adds Ubuntu2404 to node_os_skus_create and node_os_skus_update lists to enable the option in nodepool add and update commands |
| src/azure-cli/azure/cli/command_modules/acs/_help.py | Updates the help text for the --os-sku parameter in az aks nodepool add to include Ubuntu2404 as a supported option |
| src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py | Adds test test_aks_nodepool_add_with_ossku_ubuntu2404 to verify the new OS SKU option works correctly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| self.check('provisioningState', 'Succeeded'), | ||
| ]) | ||
|
|
||
| # nodepool get-upgrades |
There was a problem hiding this comment.
The comment # nodepool get-upgrades is misleading. The code below is actually calling aks nodepool add, not aks nodepool get-upgrades. This comment should be updated to accurately reflect the operation being tested, such as # nodepool add with Ubuntu2404.
| # nodepool get-upgrades | |
| # nodepool add with Ubuntu2404 |
az aks nodepool add/update: Add option Ubuntu2404 to --os-sku parameter
|
|
||
| @AllowLargeResponse() | ||
| @AKSCustomResourceGroupPreparer(random_name_length=17, name_prefix='clitest', location='eastus2euap') | ||
| def test_aks_nodepool_add_with_ossku_ubuntu2404(self, resource_group, resource_group_location): |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
az aks nodepool add/update: Add option Ubuntu2404 to --os-sku parameteraz aks nodepool add/update: Add option Ubuntu2404 to --os-sku parameter
[AKS] Add option Ubuntu2404 to
--os-skuforaz aks nodepool addandaz aks nodepool updateRelated command
az aks nodepool addaz aks nodepool updateDescription
Customers can use this parameter to select Ubuntu2404 as OSSKU when creating Linux nodepools.
Testing Guide
azdev test --live test_aks_nodepool_add_with_ossku_ubuntu2404
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.