Conversation
rashmichandrashekar
requested review from
FumingZhang,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull request overview
This PR adds support for two new Azure cloud environments (Azure Bleu Cloud and Azure Delos Cloud) to the AKS monitoring addon configuration. The changes enable default Log Analytics workspace region mapping for these sovereign clouds, following the same pattern used for existing clouds like Azure China, Azure US Government, USNat, and USSec.
Changes:
- Added region-to-OMS mappings for Azure Bleu Cloud (France Central and France South regions)
- Added region-to-OMS mappings for Azure Delos Cloud (Germany Central and Germany North regions)
- Extended cloud detection logic to handle the new cloud environments
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Please fix the failed CI check (update the PR title)
rashmichandrashekar
changed the title
|
please refer to this doc (https://github.com/Azure/azure-cli/tree/dev/doc/authoring_command_modules#submitting-pull-requests) to refine the title to include more details like impacted commands/parameters, as it will show up in our release notes. |
Thanks @yanzhudd. Updated description. But for some reason unable to edit the title. |
FumingZhang
changed the title
az aks enable-addons: Add bleu and delos default workspace region support
FumingZhang
changed the title
az aks enable-addons: Add bleu and delos default workspace region supportaz aks enable-addons: Adds support for default workspace creation in Bleu and Delos clouds
FumingZhang
changed the title
az aks enable-addons: Adds support for default workspace creation in Bleu and Delos cloudsaz aks enable-addons: Add support for default workspace creation in Bleu and Delos clouds
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Thanks @FumingZhang. Can we just rerun? Is this transient? |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 32753 in repo Azure/azure-cli |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@FumingZhang - Retries dont seem to be working.. Anything else we can do to unblock this pr merge? |
Nothing to do except wait for the CLI team to fix the CI, since they are responsible for it. |
|
Hi @rashmichandrashekar @FumingZhang |
Thanks @yanzhudd . Is this resolved now? |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
seems it's resolved, just requeued CI |
4 participants
Related command
az aks enable-addons -a monitoring
Description
The az aks command to enable monitoring addon doesn't support Bleu and Delos cloud currently when no workspace is provided. This PR adds support for this.
Testing Guide
az aks enable-addons -a monitoring -g -n
in bleu/delos cloud
History Notes
[AKS]
az aks enable-addons: Add support for default workspace creation in Bleu and Delos cloudsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.