Conversation
…list/delete` from api version 2026-04-01 for preview
️✔️AzureCLI-FullTest
|
|
Hi @calvinhzy, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| storage advanced-platform-metric | sub group storage advanced-platform-metric added |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
requested review from
evelyn-ys and
yonzhan
microsoft-github-policy-service
Bot
added
Storage
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new Storage command group az storage advanced-platform-metric (2026-04-01 API version) with CRUD operations and a custom update behavior, plus scenario coverage and recordings in the storage module.
Changes:
- Introduces AAZ-generated commands for
create/show/list/update/deleteunderstorage advanced-platform-metric. - Adds a custom
AdvancedPlatformMetricUpdatewrapper to relax the required rule-type argument and normalize filter values forAllContainersFilter. - Adds scenario test + recording for the new command group.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/storage/tests/latest/test_storage_advanced_platform_metric_scenarios.py | New scenario test covering create/show/update/list/delete flows. |
| src/azure-cli/azure/cli/command_modules/storage/tests/latest/recordings/test_storage_advanced_platform_metric.yaml | Test recording for the new scenario. |
| src/azure-cli/azure/cli/command_modules/storage/operations/advanced_platform_metric.py | Custom wrapper for update to default rule type and normalize filter values. |
| src/azure-cli/azure/cli/command_modules/storage/commands.py | Wires the custom update command into the command table. |
| src/azure-cli/azure/cli/command_modules/storage/aaz/latest/storage/advanced_platform_metric/_create.py | AAZ-generated create command and argument schema. |
| src/azure-cli/azure/cli/command_modules/storage/aaz/latest/storage/advanced_platform_metric/_update.py | AAZ-generated update command (generic update enabled). |
| src/azure-cli/azure/cli/command_modules/storage/aaz/latest/storage/advanced_platform_metric/_show.py | AAZ-generated show command. |
| src/azure-cli/azure/cli/command_modules/storage/aaz/latest/storage/advanced_platform_metric/_list.py | AAZ-generated list command with pagination support. |
| src/azure-cli/azure/cli/command_modules/storage/aaz/latest/storage/advanced_platform_metric/_delete.py | AAZ-generated delete command with confirmation. |
| src/azure-cli/azure/cli/command_modules/storage/aaz/latest/storage/advanced_platform_metric/init.py | Package exports for the new command group. |
| src/azure-cli/azure/cli/command_modules/storage/aaz/latest/storage/advanced_platform_metric/__cmd_group.py | Registers the new command group. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+7
to
+11
| from knack.log import get_logger | ||
|
|
||
| logger = get_logger(__name__) | ||
|
|
||
|
|
There was a problem hiding this comment.
logger is defined but never used in this module. Please remove the unused logger (or add a log statement if it’s intended) to avoid lint failures and keep the customization minimal.
Suggested change
| from knack.log import get_logger | |
| logger = get_logger(__name__) |
VeryEarly
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
New command
az storage advanced-platform-metric create/update/show/list/deletefrom 2026-04-01aaz Azure/aaz#987
Testing Guide
History Notes
[Storage]
az storage advanced-platform-metric create/update/show/list/delete: Support Advanced Platform MetricsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.