Conversation
…g change warning as it has been postponed.
️✔️AzureCLI-FullTest
|
|
Hi @calvinhzy, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| storage account create | cmd storage account create removed property deprecate_info_target |
||
| storage account update | cmd storage account update removed property deprecate_info_target |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
requested review from
evelyn-ys and
yonzhan
microsoft-github-policy-service
Bot
added
Storage
There was a problem hiding this comment.
Pull request overview
This PR updates the user-facing messaging around az storage account create/update --min-tls-version, and removes the breaking-change warning registration that previously announced TLS 1.0/1.1 retirement/removal.
Changes:
- Update
--min-tls-versionhelp text forstorage account createandstorage account updateto note TLS 1.3 is not supported and recommend TLS 1.2. - Remove breaking change warning registrations related to TLS 1.0/1.1 from the storage module.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/storage/_params.py |
Updates --min-tls-version help text for create/update argument definitions. |
src/azure-cli/azure/cli/command_modules/storage/_breaking_change.py |
Removes register_other_breaking_change calls for TLS 1.0/1.1 messaging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -390,8 +390,7 @@ def load_arguments(self, _): # pylint: disable=too-many-locals, too-many-statem | |||
| 'public access setting for a container is required to enable anonymous access.') | |||
| c.argument('min_tls_version', arg_type=get_enum_type(t_tls_version), | |||
| help='The minimum TLS version to be permitted on requests to storage. ' | |||
There was a problem hiding this comment.
The --min-tls-version help text no longer matches the command behavior: storage account create/update still accepts TLS1_0/TLS1_1 but silently coerces them to TLS1_2 (with a warning) in storage/operations/account.py. Consider updating this help to explicitly state that TLS1_0 and TLS1_1 are retired and will be treated as TLS1_2, so users aren’t surprised by the resulting value.
| help='The minimum TLS version to be permitted on requests to storage. ' | |
| help='The minimum TLS version to be permitted on requests to storage. ' | |
| 'TLS1_0 and TLS1_1 are retired and will be treated as TLS1_2. ' |
| @@ -509,8 +508,7 @@ def load_arguments(self, _): # pylint: disable=too-many-locals, too-many-statem | |||
| 'public access setting for a container is required to enable anonymous access.') | |||
| c.argument('min_tls_version', arg_type=get_enum_type(t_tls_version), | |||
| help='The minimum TLS version to be permitted on requests to storage. ' | |||
There was a problem hiding this comment.
Same as storage account create: this --min-tls-version help text doesn’t mention that TLS1_0 and TLS1_1 inputs are coerced to TLS1_2 by the implementation (with a warning) in storage/operations/account.py. Please reflect that in the help so the CLI behavior is transparent.
| help='The minimum TLS version to be permitted on requests to storage. ' | |
| help='The minimum TLS version to be permitted on requests to storage. ' | |
| 'TLS1_0 and TLS1_1 inputs are coerced to TLS1_2 with a warning. ' |
Related command
Description
Testing Guide
History Notes
[Storage]
az storage account create/update: Update description for tls 1.3 being not yet available, remove breaking change warning to deprecate tls1.0, tls1.1This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.