{ACR}: Re-enable test_acr_connectedregistry_dedicated_endpoint_not_enabled#33494
Merged
yanzhudd merged 1 commit intoJun 5, 2026
Conversation
PR Azure#33060 added @live_only() to skip this test in replay mode after the SDK split in PR Azure#33017 (azure-mgmt-containerregistry 15.1.0b1) converted RegistriesOperations.update into an async LRO (begin_update). The caller in connected_registry.py kept using the returned poller as a finished result, so the cassette stopped matching real traffic. PR Azure#33040 already shipped the real fix on dev: it wraps acr_update_set in LongRunningOperation(cmd.cli_ctx)(...) and refreshes the cassette with the LRO polling interactions. The test passes in replay mode against current dev (verified locally, ~14s). This change drops the now-unnecessary @live_only() decorator and its unused import.
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes the live_only constraint from an ACR connected registry scenario test so it can run in non-live test modes.
Changes:
- Dropped the
live_onlyimport. - Removed the
@live_only()decorator fromtest_acr_connectedregistry_dedicated_endpoint_not_enabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
microsoft-github-policy-service
Bot
requested review from
northtyphoon and
terencet-dev
Collaborator
|
ACR |
yanzhudd
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
N/A - test infrastructure only.
Description
PR #33060 added
@live_only()to skip this test in replay mode after the SDK split in PR #33017 convertedRegistriesOperations.updateinto an async LRO (begin_update). The caller in connected_registry.py kept using the returned poller as a finished result, so the cassette stopped matching real traffic.PR #33040 already shipped the real fix on dev: it wraps
acr_update_setinLongRunningOperation(cmd.cli_ctx)(...)and refreshes the cassette with the LRO polling interactions. The test passes in replay mode against current dev (verified locally).This change drops the now-unnecessary @live_only() decorator and its unused import.
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.