account list: add '--refresh' to sycn up the latest subscriptions from server#4091
Merged
yugangw-msft merged 7 commits intoAzure:masterfrom Jul 28, 2017
Merged
account list: add '--refresh' to sycn up the latest subscriptions from server#4091yugangw-msft merged 7 commits intoAzure:masterfrom
yugangw-msft merged 7 commits intoAzure:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4091 +/- ##
==========================================
+ Coverage 70.48% 70.49% +<.01%
==========================================
Files 437 437
Lines 28088 28134 +46
Branches 4302 4316 +14
==========================================
+ Hits 19799 19832 +33
- Misses 7009 7014 +5
- Partials 1280 1288 +8
Continue to review full report at Codecov.
|
derekbekoe
approved these changes
Jul 28, 2017
Member
derekbekoe
left a comment
derekbekoe
left a comment
There was a problem hiding this comment.
One comment on grammar but LGTM otherwise.
| subscriptions = subscription_finder.find_from_user_account(user_name, None, None, | ||
| self._ad_resource_uri) | ||
| except Exception as ex: # pylint: disable=broad-except | ||
| logger.warning("Refreshing for '%s' failed for an error '%s'. The existing accounts are not modified. " |
Member
There was a problem hiding this comment.
Suggestions on grammar:
'for an error' -> 'with an error'
'are not modified' -> 'were not modified'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #919
Command Guidelines
(see Authoring Command Modules)