Skip to content

Fix parameter name in help for az container create#4208

Merged
tjprescott merged 1 commit intoAzure:masterfrom
seanmck:aci-docfix
Aug 16, 2017
Merged

Fix parameter name in help for az container create#4208
tjprescott merged 1 commit intoAzure:masterfrom
seanmck:aci-docfix

Conversation

@seanmck
Copy link
Copy Markdown
Contributor

@seanmck seanmck commented Aug 11, 2017


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

  • Each command and parameter has a meaningful description.
  • Each new command has a test.

(see Authoring Command Modules)

@msftclas
Copy link
Copy Markdown

@seanmck,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@seanmck seanmck changed the title Aci docfix Fix parameter name in help for az container create Aug 11, 2017
@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 11, 2017

Codecov Report

Merging #4208 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4208   +/-   ##
=======================================
  Coverage   70.04%   70.04%           
=======================================
  Files         475      475           
  Lines       29602    29602           
  Branches     4539     4539           
=======================================
  Hits        20736    20736           
+ Misses       7422     7418    -4     
- Partials     1444     1448    +4
Impacted Files Coverage Δ
...ainer/azure/cli/command_modules/container/_help.py 100% <ø> (ø) ⬆️
...li-cloud/azure/cli/command_modules/cloud/custom.py 13.79% <0%> (ø) ⬆️
...dback/azure/cli/command_modules/feedback/custom.py 31.25% <0%> (ø) ⬆️
src/azure-cli-core/azure/cli/core/util.py 70.66% <0%> (ø) ⬆️
...nent/azure/cli/command_modules/component/custom.py 16.26% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bfbc32...88f5173. Read the comment docs.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't require/desire release notes for changes in help text.

@seanmck
Copy link
Copy Markdown
Contributor Author

seanmck commented Aug 15, 2017

@tjprescott: Thanks for the review. I've reverted the change to the changelog.

@tjprescott tjprescott merged commit 0d57807 into Azure:master Aug 16, 2017
@seanmck seanmck deleted the aci-docfix branch June 17, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants