Web: add node appsetting when runtime is not specified#4907
Merged
yugangw-msft merged 6 commits intoAzure:devfrom Nov 20, 2017
Merged
Web: add node appsetting when runtime is not specified#4907yugangw-msft merged 6 commits intoAzure:devfrom
yugangw-msft merged 6 commits intoAzure:devfrom
Conversation
Contributor
|
View a preview at https://prompt.ws/r/Azure/azure-cli/4907 |
panchagnula
reviewed
Nov 18, 2017
| site_config.app_settings.append(NameValuePair("WEBSITE_NODE_DEFAULT_VERSION", "6.9.1")) | ||
|
|
||
| else: # windows webapp without runtime specified | ||
| site_config.app_settings.append(NameValuePair("WEBSITE_NODE_DEFAULT_VERSION", "6.9.1")) |
Contributor
There was a problem hiding this comment.
Can you update the test to include this case as well?
Contributor
There was a problem hiding this comment.
please make 6.9.1 as a constant and reuse with the same code 2 lines above
panchagnula
approved these changes
Nov 18, 2017
Contributor
panchagnula
left a comment
panchagnula
left a comment
There was a problem hiding this comment.
Thanks for taking care of this
yugangw-msft
approved these changes
Nov 20, 2017
tjprescott
added a commit
that referenced
this pull request
Nov 27, 2017
* sp reset-credentials from dev * rebase polish rbac error message * rebase role assignment list: show default assignments for classic administrators * Modified AzureUSGov Endpoint to .US (#4877) * Modified AzureUSGov Endpoint to .US * Updated History.RST to include USGovAADEndPoint Change * Updated Setup.py to match HISTORY.RST * Reduced previous change in HISTORY.RST to a single line * HISTORY.rst merge with latest commit * HISTORY.RST Syntax Correction * webapp/functionapp: ensure list/show display correct set of apps (#4891) * Fix authoring doc typo (#4903) * Changing CLI for azure-consumption reflecting the new api-version (#4900) * Changing CLI for azure-consumption reflecting the new api-version * Modifying Setup.py and history.rst * Implementing review comments * Rebase remove component module * [acr] typo fix in help (#4904) * [acr] typo fix in help * [acr] bump version and add history line item * Rebase of support raw format on resource show * Web: add node appsetting when runtime is not specified (#4907) * webapp: fix a bug in the cert name generation (#4909) * Fix container module default ports (#4950) * fix default ports * bump up version * update history * Advisor command module (#4898) * Initial change to add Advisor module. * Add list recommendations command. * More commands. * More commands. * Pylint fixes and adding a test. * More updates. * More updates. * Fixing precheck errors. * Fixing more precheck errors. * Initial change to add Advisor module. * Add list recommendations command. * More commands. * More commands. * Pylint fixes and adding a test. * More updates. * More updates. * Fixing precheck errors. * Fixing more precheck errors. * Adding missing manifest. * Fixes for test failures. * Addressing review comments and add unit tests. * More fixes. * Address CI failures. * Extra space. * One more fix. * rebase sql usage commands. * Add advisor to default install (#4956) * Add consumption module to code owners (#4906) * Added sql server conn-policy show/update commands (#4888) * Update proj file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)