acs create: fix SP creation failures caused by new graph sdk libs#5895
Merged
Conversation
|
View a preview at https://prompt.ws/r/Azure/azure-cli/5895 |
yugangw-msft
commented
Mar 22, 2018
| key_creds = None | ||
| if password: | ||
| password_creds = [PasswordCredential(start_date, end_date, str(uuid.uuid4()), password)] | ||
| password_creds = [PasswordCredential(start_date=start_date, end_date=end_date, |
Contributor
Author
There was a problem hiding this comment.
newer sdk replaces more positional arguments to keyword arguments, hence there is a break
Moving forward, suggest let us try to convert positional ones to keyword ones even not broken.
mboersma
approved these changes
Mar 22, 2018
derekbekoe
approved these changes
Mar 23, 2018
| @@ -1158,7 +1158,7 @@ def test_vm_create_existing_ids_options(self, resource_group, storage_account): | |||
|
|
|||
|
|
|||
| # TODO: convert back to ScenarioTest when #5741 is fixed. | |||
Member
There was a problem hiding this comment.
This comment could be moved but not urgent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing issues when go over live test failures
//CC @mboersma
[na] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.