vm/vmss: use patch for updating identities#6269
Merged
Merged
Conversation
|
View a preview at https://prompt.ws/r/Azure/azure-cli/6269 |
troydai
approved these changes
May 1, 2018
|
|
||
| vm.identity = VirtualMachineIdentity(type=identity_types) | ||
| if external_identities: | ||
| external_identities[::] = set(external_identities) |
Contributor
There was a problem hiding this comment.
what's the difference between this and external_identities = list(set(external_identities))?
why not combine with next line make it
vm.identity.identity_ids = list(set(external_identities))
Contributor
Author
There was a problem hiding this comment.
It is in-place copy so to propagate the same data to outside through argument passing-by-ref, and gets picked up by the main method to display the result.
Let me add comment here to clarify the subtleness
| vmss.identity = VirtualMachineScaleSetIdentity(type=identity_types) | ||
| if external_identities: | ||
| external_identities[::] = set(external_identities) | ||
| vmss.identity.identity_ids = external_identities |
Contributor
Author
There was a problem hiding this comment.
same, will add comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Not for //build release)
The main purpose is to by-pass the access check on linked resources which otherwise would block the whole operation e.g. if the users has access to the VMSS, but not on the LB.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.