Skip to content

[Storage] Get sas-token from container url and cleanup code#6996

Merged
troydai merged 7 commits intoAzure:devfrom
williexu:url_sas
Aug 8, 2018
Merged

[Storage] Get sas-token from container url and cleanup code#6996
troydai merged 7 commits intoAzure:devfrom
williexu:url_sas

Conversation

@williexu
Copy link
Contributor

@williexu williexu commented Aug 8, 2018


This checklist is used to make sure that common guidelines for a pull request are followed.

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

  • I adhere to the Command Guidelines.

@williexu williexu requested a review from troydai August 8, 2018 20:09
@williexu williexu added the Storage az storage label Aug 8, 2018
@williexu
Copy link
Contributor Author

williexu commented Aug 8, 2018

Adding tests

g.storage_custom_command('delete-batch', 'storage_blob_delete_batch')
g.storage_custom_command('upload-batch', 'storage_blob_upload_batch', validator=process_blob_upload_batch_parameters)
g.storage_custom_command('download-batch', 'storage_blob_download_batch', validator=process_blob_download_batch_parameters)
g.storage_custom_command('delete-batch', 'storage_blob_delete_batch', validator=process_blob_delete_batch_parameters)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too long, break the line.

@williexu williexu added this to the Sprint 43 milestone Aug 8, 2018
@troydai troydai merged commit 6cbc593 into Azure:dev Aug 8, 2018
@williexu williexu deleted the url_sas branch August 11, 2018 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accept sas token in the URL represent source and destination in blob upload-batch and download-batch command

3 participants