ServiceBus: Added validator for rights#9886
Merged
Merged
Conversation
added 2 commits
July 8, 2019 12:16
Member
|
/azurepipelines start |
|
Command 'start' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
Member
|
/azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tjprescott
suggested changes
Jul 9, 2019
Member
tjprescott
left a comment
tjprescott
left a comment
There was a problem hiding this comment.
You need to add a history entry to azure-cli's HISTORY.rst for this change.
| def validate_rights(namespace): | ||
| if 'Manage' in namespace.rights: | ||
| if 'Listen' not in namespace.rights or 'Send' not in namespace.rights: | ||
| raise CLIError('Error : Assigning \'Manage\' to --rights requires \'Listen\' and \'Send\' to be included with. e.g. --rights Manage Send Listen') |
Member
There was a problem hiding this comment.
This seems like it should be a service-side error.
Author
There was a problem hiding this comment.
Adding Service Bus PM, @axisc, can you please share your view on this?
tjprescott
approved these changes
Jul 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #5824
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.