Write test cases

Author: smittal22

cns/service/main.go

@@ -403,11 +403,17 @@ func sendRegisterNodeRequest(httpClient acn.HTTPClient, httpRestService cns.HTTP
 		return errors.Wrap(retry.Unrecoverable(err), "failed to sendRegisterNodeRequest")
 	}
 
-	response, err := httpClient.Post(registerURL, "application/json", body.Bytes())
+	request, err := http.NewRequest(http.MethodPost, registerURL, &body)
 	if err != nil {
-		logger.Errorf("[Azure CNS] Failed to register node with retryable err: %+v", err)
-		return errors.Wrap(err, "failed to sendRegisterNodeRequest")
+		return errors.Wrap(err, "failed to build request")
 	}
+
+	request.Header.Set("Content-Type", "application/json")
+	response, err := httpClient.Do(request)
+	if err != nil {
+		return errors.Wrap(err, "http request failed")
+	}
+
 	defer response.Body.Close()
 
 	if response.StatusCode != http.StatusOK {

cns/service/main_test.go

@@ -21,7 +21,7 @@ type MockHTTPClient struct {
 }
 
 // Post is the implementation of the Post method for MockHTTPClient
-func (m *MockHTTPClient) Post(_, _ string, _ []byte) (*http.Response, error) {
+func (m *MockHTTPClient) Do(_ *http.Request) (*http.Response, error) {
 	return m.Response, m.Err
 }
 

common/utils.go

@@ -4,7 +4,6 @@
 package common
 
 import (
-	"bytes"
 	"context"
 	"encoding/binary"
 	"encoding/json"
@@ -81,15 +80,16 @@ type metadataWrapper struct {
 
 // HTTPClient interface to abstract http.Client methods
 type HTTPClient interface {
-	Post(url, contentType string, body []byte) (*http.Response, error)
+	Do(req *http.Request) (*http.Response, error)
 }
 
 // StandardHTTPClient is a standard implementation of the HTTPClient interface
 type StandardHTTPClient struct{}
 
-// Post is the implementation of the Post method for StandardHTTPClient
-func (c *StandardHTTPClient) Post(url, contentType string, body []byte) (*http.Response, error) {
-	return http.Post(url, contentType, bytes.NewBuffer(body))
+// Do is the implementation of the Post method for StandardHTTPClient
+func (c *StandardHTTPClient) Do(req *http.Request) (*http.Response, error) {
+	client := http.Client{}
+	return client.Do(req)
 }
 
 // Creating http client object to be reused instead of creating one every time.