chore: tidy up nmagent client for context timeouts #1056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
force-pushed
the
x/nmagent-client
branch
from
b40da22 to
7a0c11d
Compare
rbtr
requested review from
csfmomo,
pjohnst5 and
ramiro-gamarra
and removed request for
csfmomo
Contributor
ramiro-gamarra
left a comment
ramiro-gamarra
left a comment
There was a problem hiding this comment.
couple comments, let me know what you think
rbtr
force-pushed
the
x/nmagent-client
branch
from
0bdf8b4 to
66c3bc7
Compare
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rbtr
force-pushed
the
x/nmagent-client
branch
4 times, most recently
from
68227a9 to
4238f81
Compare
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
rbtr
force-pushed
the
x/nmagent-client
branch
from
493321b to
50e61a2
Compare
rbtr
force-pushed
the
x/nmagent-client
branch
from
50e61a2 to
041a91e
Compare
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
rbtr
force-pushed
the
x/nmagent-client
branch
from
9c5b2d6 to
67a522d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Evan Baker rbtr@users.noreply.github.com
Reason for Change:
HTTPRestService.SyncHostNCVersionsignificantly.Issue Fixed:
Closes #850
Fixes #855
Requirements:
Notes: