[NPM] Moving v1 netpol controller into its new location #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JungukCho
reviewed
Nov 3, 2021
Contributor
JungukCho
left a comment
JungukCho
left a comment
There was a problem hiding this comment.
Thank you for decoposing PR. It is much easier to review it.
I put some comments.
JungukCho
previously approved these changes
Nov 3, 2021
| "k8s.io/client-go/kubernetes/scheme" | ||
| ) | ||
|
|
||
| var testPolicyDir = "../../../../" |
Contributor
There was a problem hiding this comment.
nitpick: if possible, const is better to make accidental mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving all v1 controllers and helper files into their new location. Also fixing a couple of issues in windows policy from master