refactor: move from io/ioutil to io and os packages #1096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
rbtr
previously approved these changes
Nov 10, 2021
Collaborator
rbtr
left a comment
rbtr
left a comment
There was a problem hiding this comment.
thanks, lgtm!
/cc @ramiro-gamarra
Contributor
Author
|
@rbtr The Azure pipelines seems to be rate limited. I just received an email saying that the requests are being blocked. |
Collaborator
|
we've got some unrelated pipeline problems being fixed; will need you to rebase the PR when that is all fixed and we can move this forward |
rbtr
previously approved these changes
Nov 16, 2021
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
The io/ioutil package has been deprecated as of Go 1.16, see https://golang.org/doc/go1.16#ioutil. This commit replaces the existing io/ioutil functions with their new definitions in io and os packages. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Collaborator
|
hey @Juneezee we squash and merge, so unless there's conflicts you don't need to keep rebasing a minor change like this 🙂 it confuses the CI |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
JungukCho
approved these changes
Nov 17, 2021
Contributor
JungukCho
left a comment
JungukCho
left a comment
There was a problem hiding this comment.
lgtm! Thank you for contributing codes.
rbtr
approved these changes
Nov 17, 2021
Collaborator
|
tyvm @Juneezee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
The
io/ioutilpackage has been deprecated in Go 1.16 (See https://golang.org/doc/go1.16#ioutil). Since this project has been upgraded to Go 1.17 in #1042, this PR replaces the existingio/ioutilfunctions with their new definitions inioandospackages.Issue Fixed:
Requirements:
Notes: