Fix the NC ID error when get container #1767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csfmomo
requested review from
ashvindeodhar and
thatmattlong
and removed request for
a team
ashvindeodhar
requested changes
Jan 24, 2023
ashvindeodhar
previously approved these changes
Jan 24, 2023
csfmomo
force-pushed
the
v2Fix
branch
5 times, most recently
from
d63908a to
79313e8
Compare
pjohnst5
previously approved these changes
Feb 6, 2023
pjohnst5
previously approved these changes
Feb 6, 2023
ashvindeodhar
previously approved these changes
Feb 6, 2023
ashvindeodhar
approved these changes
Feb 7, 2023
rjdenney
pushed a commit
that referenced
this pull request
Mar 13, 2023
* Fix nc id mismatch * Fix the nc ID prefix issue
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: repair the NC ID mismatch when get network container.
Reason for Change:
Fix the mismatch between NC version returned from nmagent and CNS state. Add unit test to gate it.
Issue Fixed:
CNS is onboard with nmagent nc version api 2. NC ID returned from nmagent doesn't include the Swift_ prefix but pure uuid. However, the NC ID in the request and cns state has the Swift_ prefix. This mismatch result in the nc version update failure.
Requirements:
Notes: