fix: Adding a defer func to connecttoTelemetryservice() to prevent CNI fro… #1800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamilmani1989
requested changes
Feb 10, 2023
| func (tb *TelemetryBuffer) ConnectCNIToTelemetryServiceAttempt(telemetryNumRetries, telemetryWaitTimeInMilliseconds int, netPlugin *cni.Plugin, path string, args []string) error { | ||
| if err := tb.Connect(); err != nil { | ||
| log.Logf("Connection to telemetry socket failed: %v", err) | ||
| if runtime.GOOS == "windows" { |
Member
There was a problem hiding this comment.
can you also place defer under this if..so no need to check if windows in 2 places
Contributor
Author
There was a problem hiding this comment.
addressed in the new commit
tamilmani1989
requested changes
Feb 10, 2023
telemetry/telemetrybuffer.go
Outdated
| } | ||
| if err = StartTelemetryService(path, args); err != nil { | ||
| return errors.Wrap(err, "StartTelemetryService failed") | ||
| if err := tb.ConnectCNIToTelemetryServiceAttempt(telemetryNumRetries, telemetryWaitTimeInMilliseconds, netPlugin, path, args); err != nil { |
Member
There was a problem hiding this comment.
can we rename this as startAndConnectTelemetryService
Contributor
Author
There was a problem hiding this comment.
addressed in the new commit.
behzad-mir
force-pushed
the
behzadm-telemetryservice-defer
branch
from
cb9e27c to
08b5782
Compare
…m stucking in case of telemetry service failure.
behzad-mir
force-pushed
the
behzadm-telemetryservice-defer
branch
from
14400ef to
606431f
Compare
tamilmani1989
approved these changes
Feb 11, 2023
rjdenney
pushed a commit
that referenced
this pull request
Mar 13, 2023
…I fro… (#1800) * Adding a defer func to connecttoTelemetryservice() to prevent CNI from stucking in case of telemetry service failure. * fix: addressing the comments for telemetry defer function. * fix: addressing the comments for telemetry defer func.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a defer func to connecttoTelemetryservice()
Reason for Change:
to prevent CNI from stucking when the telemetry service is unable to start.