Skip to content

log: [NPM-WIN] clean up some logs #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2023
Merged

log: [NPM-WIN] clean up some logs #1807

merged 2 commits into from
Feb 24, 2023

Conversation

@huntergregory
Copy link
Contributor

@huntergregory huntergregory commented Feb 16, 2023

  1. remove remote endpoint log (superfluous info that dilutes logs)
  2. change wording for warning
  3. more understandable logs when resetting all ACLs

@huntergregory huntergregory added npm Related to NPM. windows labels Feb 16, 2023
@huntergregory huntergregory requested a review from a team as a code owner February 16, 2023 21:57
@huntergregory huntergregory requested review from ck319 and removed request for a team February 16, 2023 21:57
@vakalapa vakalapa merged commit 6989215 into master Feb 24, 2023
@vakalapa vakalapa deleted the hgregory/npm-pmgr-win-logs branch February 24, 2023 22:16
rjdenney pushed a commit that referenced this pull request Mar 13, 2023
@huntergregory @vakalapa @rjdenney
log: [NPM-WIN] clean up some logs (#1807)
f31b0ad 
clean up some logs

Co-authored-by: Vamsi Kalapala <vakr@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vakalapa vakalapa vakalapa approved these changes

@ck319 ck319 Awaiting requested review from ck319 ck319 is a code owner automatically assigned from Azure/acn-npm-reviewers

Assignees

No one assigned

Labels

npm Related to NPM. windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huntergregory @vakalapa