upgrade goldpinger version and increase ping/check timeout #1810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timraymond
previously approved these changes
Feb 21, 2023
Member
timraymond
left a comment
timraymond
left a comment
There was a problem hiding this comment.
Changes seem reasonable to me 👍
increase the check/check_all/dns timeout
timraymond
requested changes
Feb 22, 2023
Member
timraymond
left a comment
timraymond
left a comment
There was a problem hiding this comment.
Small request: If these configs now allow units, it would be more obvious to readers to use seconds instead of making them do the math.
estebancams
approved these changes
Feb 22, 2023
timraymond
approved these changes
Feb 23, 2023
rjdenney
pushed a commit
that referenced
this pull request
Mar 13, 2023
* upgrade goldpinger version and increase ping/check timeout * replace the deprecated timeout config with latest one increase the check/check_all/dns timeout * use straightforward unit in config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: