fix: [NPM-WIN] do not refresh endpoints if pod cache is empty #1831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntergregory
suggested changes
Mar 2, 2023
| // NOTE: ideally we won't refresh Pod Endpoints if the updatePodCache is empty | ||
| if dp.shouldUpdatePod() { | ||
| // do not refresh endpoints if the updatePodCache is empty | ||
| if len(dp.updatePodCache.cache) == 0 { |
Contributor
There was a problem hiding this comment.
will need to lock the cache
Contributor
There was a problem hiding this comment.
Locking the updatePodCache while refreshing Endpoints would be a regression in the sense that it would block Pod controller from doing any dataplane operations (e.g. AddToSets() and applyIPSets()).
vakalapa
previously approved these changes
Mar 2, 2023
huntergregory
approved these changes
Mar 3, 2023
rjdenney
pushed a commit
that referenced
this pull request
Mar 13, 2023
* do not refresh endpoints if pod cache is empty * moved cache lock up * reposition cache lock * fixed incorrect logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Not refreshing when not necessary improves NPM efficiency
Issue Fixed:
Requirements:
Notes: