ci: [WIN-NPM] remove ws19 build #1844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
rbtr
approved these changes
Mar 9, 2023
Collaborator
|
looks like these OS_VERSIONs set in the pipeline step are not being propogated - the Makefile should probably say |
rbtr
requested changes
Mar 9, 2023
Collaborator
rbtr
left a comment
rbtr
left a comment
There was a problem hiding this comment.
needs Makefile fix for OS_VERSIONS (can you update the CNS manifest target also?)
rbtr
approved these changes
Mar 9, 2023
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
vakalapa
approved these changes
Apr 6, 2023
3 tasks
jpayne3506
pushed a commit
that referenced
this pull request
Jun 26, 2024
* remove NPM build for ws19 * set OS versions by variable in manifest-build --------- Co-authored-by: Vamsi Kalapala <vakr@microsoft.com>
jpayne3506
added a commit
that referenced
this pull request
Jun 26, 2024
* ci: Change ACR Service Connection (#2727) * fix: pin Windows images (#2742) Signed-off-by: Evan Baker <rbtr@users.noreply.github.com> * ci: [WIN-NPM] remove ws19 build (#1844) * remove NPM build for ws19 * set OS versions by variable in manifest-build --------- Co-authored-by: Vamsi Kalapala <vakr@microsoft.com> --------- Signed-off-by: Evan Baker <rbtr@users.noreply.github.com> Co-authored-by: Evan Baker <rbtr@users.noreply.github.com> Co-authored-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com> Co-authored-by: Vamsi Kalapala <vakr@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unnecessary build. NPM isn't supported on Windows Server 2019