Dualstack Overlay CNI #1866

rjdenney · 2023-03-21T17:29:22Z

Reason for Change:

This PR is to provide dualStack CNI changes to create a NC with both ipv4 and ipv6 address in dualStackOverlay mode on both Windows&Linux OS

The PR includes following UTs:
(1) RequestIPs() => request ipv4 & ipv6 ip addresses and make sure dual-stack NC creation
(2) RequestIPAddress() => request only ipv4 and make sure single-stack NC is working fine
(3) ReleaseIPs() => release ipv4 & ipv6 ip addresses and make sure they are released
(4) ReleaseIPAddress() => release ipv4 address only and make sure this ipv4 address can be released in single-tenancy

Tests we did manually(on both Linux and Windows):
(1) Network(ipv4+ipv6):
    pod -> pod (one node and different nodes)
    pod -> host
    host -> pod
    pod -> internet
    host -> internet

(2) Launched dual stack overlay cluster in different regions: eastus, eastuseuap, centraluseuap
(3) Test Different Linux OSs (including Ubuntu 19, Ubunt22 and CLB-Mariner)
(4) Test different Linux processors (ARM/AMDH&I)
(5) NMAgent tests
(6) HNS tests: https://microsoftapc-my.sharepoint.com/personal/ppereira_microsoft_com/_layouts/15/onedrive.aspx?id=%2Fpersonal%2Fppereira%5Fmicrosoft%5Fcom%2FDocuments%2FDocuments%2FProjects%2FAKS%2DIPV6%2DSupport&ct=1680642656649&or=Teams%2DHL&ga=1

Issue Fixed:

Requirements:

uses conventional commit messages
includes documentation
adds unit tests

Notes:

network/network_windows.go

cni/network/network_windows.go

cni/network/network.go

cni/network/network_test.go

cni/network/invoker.go

vipul-21 · 2023-03-21T20:50:27Z

cni/network/invoker_azure.go

 			if len(addResult.ipv4Result.IPs) > 0 {
-				if er := invoker.Delete(&addResult.ipv4Result.IPs[0].Address, addConfig.nwCfg, nil, addConfig.options); er != nil {
+				addresses := []*net.IPNet{}
+				for _, ip := range addResult.ipv4Result.IPs {


Here we are appending from ipv4 result. And in the delete function we are deleting the ipv6 addresses as well. Correct me if am wrong but shouldn't we have the ipv6 addresses in the list too ?
OR am i missing something ? we can add a comment describing what the intent of this function is.

@paulyufan can you repond to this comment?

Hi, I missed this comment, yes, we do need delete ipv6 addresses here as well

vipul-21 · 2023-03-21T20:50:36Z

cni/network/invoker_cns.go

+			if net.ParseIP(info.podIPAddress).To4() != nil {
+				ncgw = net.ParseIP(overlayGatewayV4IP)
+			} else {
+				ncgw = net.ParseIP(overlayGatewayV6IP)


Should we add a condition to check that the ipv6 address is returned ? or we are sure that if not ipv4 then ipv6 is the case.

+1 on @vipul-21 comment. We should validate that it's ipv6 IP in 'else if' followed by 'esle' which returns error

yes I added this fix

cni/network/invoker_cns.go

vipul-21 · 2023-03-21T20:50:44Z

cni/network/invoker_cns.go

-		return errors.Wrap(err, fmt.Sprintf("failed to release IP %v with err ", address)+"%w")
+	if err := invoker.cnsClient.ReleaseIPs(context.TODO(), req); err != nil {
+		// if we fail a release with a 404 error try using the old API
+		if errors.Is(err, cnscli.ErrAPINotFound) {


In this case, what if the API fails a single time with 404 and we call the old API. ? Do we intend to call the old API for the subsequent calls ?
OR the old API is serving just as back up ? ( will probably produce the same results ?)

yes, we do call old API if new API does not work

cni/network/invoker_mock.go

vipul-21

Can we add a bit more description for the PR as well.
Like Reason for change, design doc etc.

network/network_windows.go

…working into dualstack-overlay-cni

cni/network/invoker_azure.go

ashvindeodhar · 2023-04-05T04:31:36Z

cni/network/invoker_azure.go

 	}

 	if len(invoker.nwInfo.Subnets) > 0 {
 		nwCfg.IPAM.Subnet = invoker.nwInfo.Subnets[0].Prefix.String()


which subnet is this referring to?

ashvindeodhar · 2023-04-05T04:33:31Z

cni/network/invoker_azure.go

+			nwCfgIpv6.IPAM.Environment = common.OptEnvironmentIPv6NodeIpam
+			nwCfgIpv6.IPAM.Type = ipamV6
+			nwCfgIpv6.IPAM.Address = address.IP.String()
+			if len(invoker.nwInfo.Subnets) > 1 {


I understand you haven't added this logic but just rearranged it. Why is invoker.nwInfo.Subnets[1] used in ipv6 path? Is that a guarantee?

I see that in the invoker_azure_test.go for ipv6 delete, it uses this nwInfo -
nwInfo: getNwInfo("10.0.0.0/24", "2001:db8:abcd:0012::0/64"),

with dualstack, do we always create nwInfo with such ipv4 and ipv6 order?

thats old code. you are right we should not make that assumption. instead we should find based on ipaddress itself.

cni/network/invoker_cns.go

ashvindeodhar · 2023-04-05T04:45:06Z

cni/network/invoker_cns.go

+				PodInterfaceID:      GetEndpointID(addConfig.args),
+				InfraContainerID:    addConfig.args.ContainerID,
+			}
+			log.Errorf("Failed to request IPs using RequestIPs from CNS, going to try RequestIPAddress. error: %v request: %v", err, ipconfig)


nit: Move this error log to line 84

In the error log I would clearly specify the failure due to api not found.
log.Errorf("RequestIPs not supported by CNS. Invoking RequestIPAddress API. request: %v", ipconfig)

ashvindeodhar · 2023-04-05T05:12:12Z

cni/network/invoker_cns.go

+			if net.ParseIP(info.podIPAddress).To4() != nil {
+				ncgw = net.ParseIP(overlayGatewayV4IP)
+			} else {
+				ncgw = net.ParseIP(overlayGatewayV6IP)


+1 on @vipul-21 comment. We should validate that it's ipv6 IP in 'else if' followed by 'esle' which returns error

cni/network/invoker_cns.go

ashvindeodhar · 2023-04-05T05:20:32Z

cni/network/invoker_cns.go

+					},
+				},
+			}
+		} else {


let's check if this is ipv6 IP here

ashvindeodhar · 2023-04-05T05:29:33Z

cni/network/invoker_cns.go

+				OrchestratorContext: orchestratorContext,
+				PodInterfaceID:      GetEndpointID(args),
+				InfraContainerID:    args.ContainerID,
+				DesiredIPAddress:    req.DesiredIPAddresses[0],


req.DesiredIPAddresses[0] can run into nil pointer deref?
what if len(addresses) check on line 289 fails? You will never initialize the slice on line 290.
Has this been tested with UT?

ashvindeodhar · 2023-04-05T05:30:47Z

cni/network/invoker_cns.go

+				InfraContainerID:    args.ContainerID,
+				DesiredIPAddress:    req.DesiredIPAddresses[0],
+			}
+			log.Errorf("Failed to release IPs using ReleaseIPs from CNS, going to try ReleaseIPAddress. error: %v request: %v", err, req)


same comment as request func. Move this up and revisit the error message.

…working into dualstack-overlay-cni

…twork is created at first time

tamilmani1989 · 2023-04-17T18:35:37Z

Makefile

+	$(MKDIR) $(CNI_DUALSTACK_BUILD_DIR)
+	cp cni/azure-$(GOOS)-swift-overlay-dualstack.conflist $(CNI_DUALSTACK_BUILD_DIR)/10-azure.conflist
+	cp telemetry/azure-vnet-telemetry.config $(CNI_DUALSTACK_BUILD_DIR)/azure-vnet-telemetry.config
+	cp $(CNI_BUILD_DIR)/azure-vnet$(EXE_EXT) $(CNI_BUILD_DIR)/azure-vnet-ipam$(EXE_EXT) $(CNI_BUILD_DIR)/azure-vnet-telemetry$(EXE_EXT) $(CNI_DUALSTACK_BUILD_DIR)


why do you need azure-vnet-ipam binary?

tamilmani1989 · 2023-04-17T20:14:44Z

cni/network/invoker_azure.go

+				}
+			} else if len(addResult.ipv6Result.IPs) > 0 {
+				if er := invoker.Delete(&addResult.ipv6Result.IPs[0].Address, addConfig.nwCfg, nil, addConfig.options); er != nil {
+					err = invoker.plugin.Errorf("Failed to clean up IPv6 during Delete with error %v, after Add failed with error %w", er, err)


why this change is required in legacy ipam? I think dualstack supported is added only with swift which uses cns

thanks Tamilmani, we do not need to change this in legacy ipam. remove these changes from legacy ipam in case to generate problems

tamilmani1989 · 2023-04-17T21:29:58Z

cni/network/invoker_cns.go

+		// if RequestIPs call fails, we may receive API not Found error as new CNS is not supported, then try old API RequestIPAddress
+		log.Errorf("RequestIPs not supported by CNS. Invoking RequestIPAddress API with infracontainerid %s", ipconfig.InfraContainerID)
+		if cnscli.IsUnsupportedAPI(err) {
+			ipconfigs := cns.IPConfigRequest{


why do we redefine ipconfigs? can we use the same defined in line 75?

because they are using different structure:
ipConfigs: IPConfigsRequest
ipConfig: IPConfigRequest

tamilmani1989 · 2023-04-17T21:31:50Z

cni/network/invoker_cns.go

 	}

-	ipconfig := cns.IPConfigRequest{
+	ipconfig := cns.IPConfigsRequest{


can it be ipconfigs instead?

tamilmani1989 · 2023-04-17T21:39:45Z

cni/network/invoker_cns.go

+					return IPAMAddResult{}, err
+				}
+			} else if net.ParseIP(info.podIPAddress).To16() != nil {
+				ncgw = net.ParseIP(overlayGatewayV6IP)


can we confirm with hns team if gw ip configuration correct? when last checked for ipv4 overlay, sravanth mentioned gw address should be from same subnet of NC.

yes, we got this fixed ipv6 gateway from HNS team

yes, HNS team gave this and we do not have this requirement for now because Jaeryn fixed this before was to fix overlay gateway bug that prevented cloud-node-manager-windows from initializing node because it couldn't reach IMDS. An additional VFP rule was implicitly plumbed by HNS to add 169.254.1.1/16 to the exception list. This is most likely based off the RouteConfiguration in the "azure" HNS network. This additional VFP rule was skipping SNAT for any IP address in this range 169.254.0.0-169.254.255.255. We'll set the first .1 IP of podcidr as the gateway now.

Regarding this "We'll set the first .1 IP of podcidr as the gateway now."

in this case, cni sets "fe80::1234:5678:9abc" as gw ip and its not first ip of podcidr. This is exactly the same problem with ipv4 and hns team said gateway ip should be within pod cidr.. i know jaeryn made this change (making gw ip as first ip of pod cidr) for imds to work but that's the right way to do it whether it works or not as per hns team

setting this gw ip "fe80:🔢5678:9abc" is correct for linux but may not be for windows. if you have got approval from sravanth/hns team on this, im good

tamilmani1989 · 2023-04-17T22:37:44Z

cni/network/network.go

 		}

-		log.Printf("[cni-net] ADD command completed for pod %v with IPs:%+v err:%v.", k8sPodName, ipamAddResult.ipv4Result.IPs, err)
+		if ipamAddResult.ipv4Result.IPs != nil {


isn't that behaviour same even before? we didn't see any crash before..

tamilmani1989 · 2023-04-17T22:41:12Z

cni/network/network.go

+
 	setNetworkOptions(ipamAddResult.ncResponse, &nwInfo)

 	addNatIPV6SubnetInfo(ipamAddConfig.nwCfg, ipamAddResult.ipv6Result, &nwInfo)


it does the same thing. lets remove that.anyway we are not supporting ipv6nat mode

tamilmani1989 · 2023-04-17T22:43:16Z

cni/network/network.go

+	ipv4Subnet := network.SubnetInfo{
+		Family:  platform.AfINET,
+		Prefix:  *podSubnetPrefix,
+		Gateway: ipamAddResult.ipv4Result.IPs[0].Gateway,
+	}
+	nwInfo.Subnets = append(nwInfo.Subnets, ipv4Subnet)
+
+	if ipamAddResult.ipv6Result != nil && len(ipamAddResult.ipv6Result.IPs) > 0 {
+		ipv6Subnet := network.SubnetInfo{
+			Family:  platform.AfINET6,
+			Prefix:  *podSubnetV6Prefix,
+			Gateway: ipamAddResult.ipv6Result.IPs[0].Gateway,
+		}
+		nwInfo.Subnets = append(nwInfo.Subnets, ipv6Subnet)
+	}


the function is growing bigger.. you can define internal function like constructNetworkInfo and move initializing network info and assigning these subnets under that?

tamilmani1989 · 2023-04-17T22:44:39Z

cni/network/network.go


 	if opt.resultV6 != nil {
+		// inject routes to linux pod
+		epInfo.IPV6Mode = network.DualStackOverlay


why ipv6Mode is concluded as DualstackOverlay and how do we handle if we support podsubnet(vnet) for ipv6 tomorrow?

also where we are using this field?

tamilmani1989 · 2023-04-17T22:51:11Z

cni/network/network.go


 		if !nwCfg.MultiTenancy {
 			// Call into IPAM plugin to release the endpoint's addresses.
+			logAndSendEvent(plugin, fmt.Sprintf("Releasing ips:%+v", epInfo.IPAddresses))


i would prefer not changing this. anyway it will add one more extra log which is fine imo.. it will give more clarity on ip has been released and what not

tamilmani1989 · 2023-04-17T22:55:43Z

network/network_windows.go

 			log.Printf("[net] Successfully created hcn network with response: %+v", hnsResponse)
+
+			// only add net rules if it's dualStackOverlay mode and hnsNetwork is created at first time
+			if util.DualStackOverlay == DualStackOverlay {


trying to understand the significance of this check.. isn't these comparing 2 constant variables?

tamilmani1989 · 2023-04-17T22:56:20Z

cni/network/network.go


 	if opt.resultV6 != nil {
+		// inject routes to linux pod
+		epInfo.IPV6Mode = network.DualStackOverlay


also where we are using this field?

…working into dualstack-overlay-cni

cni/network/invoker_azure.go

ashvindeodhar · 2023-04-20T03:51:36Z

cni/network/invoker_cns.go

-		log.Printf("Failed to get IP address from CNS with error %v, response: %v", err, response)
-		return IPAMAddResult{}, errors.Wrap(err, "Failed to get IP address from CNS with error: %w")
+		// if RequestIPs call fails, we may receive API not Found error as new CNS is not supported, then try old API RequestIPAddress
+		log.Errorf("RequestIPs not supported by CNS. Invoking RequestIPAddress API with infracontainerid %s", ipconfigs.InfraContainerID)


this error log should be moved after line 86. We shouldn't log this error if the error is not of the type UnSupportedAPI

ashvindeodhar · 2023-04-20T03:52:31Z

cni/network/invoker_cns.go

 	if err != nil {
-		log.Printf("Failed to get IP address from CNS with error %v, response: %v", err, response)
-		return IPAMAddResult{}, errors.Wrap(err, "Failed to get IP address from CNS with error: %w")
+		// if RequestIPs call fails, we may receive API not Found error as new CNS is not supported, then try old API RequestIPAddress


nit comment: If RequestIPs is not supported by CNS, use RequestIPAddress API

ashvindeodhar · 2023-04-20T03:55:52Z

cni/network/invoker_cns.go


-	log.Printf("[cni-invoker-cns] Received info %+v for pod %v", info, podInfo)
+		// set the NC Primary IP in options
+		// SNATIPKey set is not for ipv6


nit: is not set for

ashvindeodhar · 2023-04-20T03:57:30Z

cni/network/invoker_cns.go

-	if ncgw == nil {
-		if invoker.ipamMode != util.V4Overlay {
-			return IPAMAddResult{}, errors.Wrap(errInvalidArgs, "%w: Gateway address "+info.ncGatewayIPAddress+" from response is invalid")
+		// set result ipconfigArgument from CNS Response Body


is this comment placed correctly?
// set result ipconfigArgument from CNS Response Body

not sure what it means

ashvindeodhar · 2023-04-20T05:41:36Z

network/network_windows.go

+
+			// netsh interface ipv4 add route $subnetV4 $hostInterfaceAlias $gatewayV4
+			netshV4GatewayRoute := fmt.Sprintf(netRouteCmd, "ipv4", prefix, ifName, gateway)
+			log.Printf("[net] Adding ipv4 gateway route failed: %v:%v", out, err)


this log line is just incorrect. Looks like copy paste error

ashvindeodhar · 2023-04-20T05:43:29Z

network/network_windows.go

+			if out, err = nm.plClient.ExecuteCommand(netshV4GatewayRoute); err != nil {
+				log.Printf("[net] Adding ipv4 gateway route failed: %v:%v", out, err)
+			}
+		} else {


let's check
ip.To16() != nil {

ip, _, er := net.ParseCIDR(prefix)
ParseCIDR already handled whether prefix is valid or not, so we do not need check ip.To16() here

ashvindeodhar · 2023-04-20T05:46:22Z

network/network_windows.go

 			log.Printf("[net] Successfully created hcn network with response: %+v", hnsResponse)
+
+			// only add net rules if it's dualStackOverlay mode and hnsNetwork is created at first time
+			if string(util.DualStackOverlay) != "" {


how is this check ensuring that CNI is operating in dualstack overlay mode?

so confusing as you define multiple variables with dualstack. why don't you use epInfo.Ipv6mode

ashvindeodhar · 2023-04-20T05:52:24Z

network/network_windows.go

+			// only add net rules if it's dualStackOverlay mode and hnsNetwork is created at first time
+			if string(util.DualStackOverlay) != "" {
+				if err := nm.addNewNetRules(nwInfo); err != nil { // nolint
+					return nil, err


let's please log error here

ashvindeodhar · 2023-04-20T05:54:14Z

network/network_windows.go

+		} else {
+			// netsh interface ipv6 add route $subnetV6 $hostInterfaceAlias "::" metric=270
+			netshV6DefaultRoute := fmt.Sprintf(netRouteCmd, "ipv6", prefix, ifName, ipv6DefaultHop, "270")
+			if out, err = nm.plClient.ExecuteCommand(netshV6DefaultRoute); err != nil {


+1 these are not idempotent. If the route is already present recreating the route will fail as it complains saying the object is already present.
@paulyufan2 as discussed earlier this week, you would need to check if the route exists before creating it.

ashvindeodhar · 2023-04-20T06:00:04Z

cni/network/network.go


 	if opt.resultV6 != nil {
+		// get IPAM mode from conflist file and add ipv6 routes to linux pod if needed
+		epInfo.IPV6Mode = string(util.IpamMode(opt.nwCfg.IPAM.Mode))


I think you should only set the epInfo.IPV6Mode to that value if the string(util.IpamMode(opt.nwCfg.IPAM.Mode)) is dualStackOverlay. This will prevent setting the IPV6Mode if we are not operating in dualstack mode

tamilmani1989 · 2023-04-20T17:29:25Z

cni/azure-linux-swift-overlay-dualstack.conflist

+      {
+         "type":"azure-vnet",
+         "mode":"transparent",
+         "executionMode":"v4swift",


shouldn't this be "dualstackswift"?

tamilmani1989 · 2023-04-20T17:29:54Z

cni/azure-windows-swift-overlay-dualstack.conflist

+            "type": "azure-vnet",
+            "mode": "bridge",
+            "bridge": "azure0",
+            "executionMode": "v4swift",


same as above

tamilmani1989 · 2023-04-20T17:31:58Z

cni/network/invoker_azure.go

-			nwCfgIpv6.IPAM.Subnet = invoker.nwInfo.Subnets[1].Prefix.String()
+			for _, subnet := range invoker.nwInfo.Subnets {
+				if subnet.Prefix.IP.To4() == nil {
+					nwCfgIpv6.IPAM.Subnet = subnet.Prefix.String()


break from for loop after finding ipv6 subnet?

tamilmani1989 · 2023-04-20T17:36:49Z

cni/network/invoker_cns.go

+					return IPAMAddResult{}, err
+				}
+			} else if net.ParseIP(info.podIPAddress).To16() != nil {
+				ncgw = net.ParseIP(overlayGatewayV6IP)


Regarding this "We'll set the first .1 IP of podcidr as the gateway now."

in this case, cni sets "fe80::1234:5678:9abc" as gw ip and its not first ip of podcidr. This is exactly the same problem with ipv4 and hns team said gateway ip should be within pod cidr.. i know jaeryn made this change (making gw ip as first ip of pod cidr) for imds to work but that's the right way to do it whether it works or not as per hns team

tamilmani1989 · 2023-04-20T17:38:35Z

cni/network/invoker_cns.go

+					return IPAMAddResult{}, err
+				}
+			} else if net.ParseIP(info.podIPAddress).To16() != nil {
+				ncgw = net.ParseIP(overlayGatewayV6IP)


setting this gw ip "fe80:🔢5678:9abc" is correct for linux but may not be for windows. if you have got approval from sravanth/hns team on this, im good

tamilmani1989 · 2023-04-20T18:26:46Z

cni/network/multitenancy_test.go


 var (
 	errUnsupportedAPI             = errors.New("Unsupported API")
+	errNoRequestIPFound           = errors.New("No Request IP Found")


i dont think we are testing actual code paths but creating these mock errors and returning from that in mock function. @paulyufan is that right?

tamilmani1989 · 2023-04-20T18:29:51Z

cni/network/network.go

+	// parse the ipv6 address and only add it to nwInfo if it's dual stack mode
+	var podSubnetV6Prefix *net.IPNet
+	if ipamAddResult.ipv6Result != nil && len(ipamAddResult.ipv6Result.IPs) > 0 {
+		_, podSubnetV6Prefix, err = net.ParseCIDR(ipamAddResult.ipv6Result.IPs[0].Address.String())
+		if err != nil {
+			return nwInfo, fmt.Errorf("Failed to ParseCIDR for pod subnet IPv6 prefix: %w", err)
+		}
+	}
+


can we move this and ipv4 parse as well to addSubnetToNetworkInfo function?

tamilmani1989 · 2023-04-20T18:31:14Z

cni/network/network.go

+		// inject ipv6 routes to Linux pod
+		ipamMode := string(util.IpamMode(opt.nwCfg.IPAM.Mode))
+		if ipamMode == "dualStackOverlay" {
+			epInfo.IPV6Mode = ipamMode


i guess instead of checking ipammode, we should set executionmode to dualstackswift and set that in epInfo.ipamMode

tamilmani1989 · 2023-04-20T18:32:47Z

dropgz/build/cniTest.Dockerfile

 COPY --from=azure-ipam /azure-ipam/bin/* pkg/embed/fs
 COPY --from=azure-vnet /azure-container-networking/cni/azure-$OS-swift.conflist pkg/embed/fs/azure-swift.conflist
 COPY --from=azure-vnet /azure-container-networking/cni/azure-$OS-swift-overlay.conflist pkg/embed/fs/azure-swift-overlay.conflist
+COPY --from=azure-vnet /azure-container-networking/cni/azure-$OS-swift-overlay-dualstack.conflist pkg/embed/fs/azure-swift-overlay-dualstack.conflist


we are moving away from copying conflist from dropgz instead cns should write conflist after NC creation

tamilmani1989 · 2023-04-20T18:37:36Z

network/network_windows.go

 			log.Printf("[net] Successfully created hcn network with response: %+v", hnsResponse)
+
+			// only add net rules if it's dualStackOverlay mode and hnsNetwork is created at first time
+			if string(util.DualStackOverlay) != "" {


so confusing as you define multiple variables with dualstack. why don't you use epInfo.Ipv6mode

…working into dualstack-overlay-cni

paulyufan2 · 2023-04-21T23:31:07Z

do not review this PR. Please use this PR: https://github.com/Azure/azure-container-networking/pull/1925/files

paulyufan added 4 commits March 21, 2023 13:00

dualstack overlay cni PR

0ba937f

rebase current branch

d056ddf

fix conflicts

adc5cab

fix conflicts

4111b40

behzad-mir reviewed Mar 21, 2023

View reviewed changes

vipul-21 reviewed Mar 21, 2023

View reviewed changes

cni/network/invoker.go Outdated Show resolved Hide resolved

vipul-21 reviewed Mar 21, 2023

View reviewed changes

cni/network/invoker_cns.go Outdated Show resolved Hide resolved

vipul-21 reviewed Mar 21, 2023

View reviewed changes

cni/network/invoker_mock.go Outdated Show resolved Hide resolved

vipul-21 reviewed Mar 21, 2023

View reviewed changes

network/network_windows.go Outdated Show resolved Hide resolved

network/network_windows.go Outdated Show resolved Hide resolved

paulyufan added 11 commits March 22, 2023 14:25

fix few comments

be7c1f0

fix comments

e3ee07e

add Jaeryn's changes

369ac15

add Jaeryn's changes

9fa2976

fix ipv4Result.IPs nil issue

a21cbe8

add RequestIPs fix from Ryan

956c653

fix UT

d1b8bea

Merge branch 'master' of https://github.com/Azure/azure-container-net…

b1ff0ab

…working into dualstack-overlay-cni

fix != issue

230d6b9

Merge branch 'master' of https://github.com/Azure/azure-container-net…

64fcc5b

…working into dualstack-overlay-cni

fix linter issue

c2ac5ff

ashvindeodhar requested changes Apr 5, 2023

View reviewed changes

paulyufan added 3 commits April 5, 2023 10:33

fix comments

4570853

Merge branch 'master' of https://github.com/Azure/azure-container-net…

4172aac

…working into dualstack-overlay-cni

fix comments

6e56bd5

paulyufan requested a review from a team as a code owner April 5, 2023 17:10

paulyufan removed the request for review from a team April 5, 2023 17:10

paulyufan added 4 commits April 14, 2023 22:28

fix conflicts

4d3a50e

add proper logs

ea7a2d4

remove nolint

e2a87f1

fix a bug to add netsh rule only it's dualStackOverlay mode and hnsne…

f57754b

…twork is created at first time

tamilmani1989 requested changes Apr 17, 2023

View reviewed changes

paulyufan2 added 10 commits April 17, 2023 20:53

comment fix part1

ac74b16

Merge branch 'master' of https://github.com/Azure/azure-container-net…

2d9af9a

…working into dualstack-overlay-cni

reorg constructNetworkInfo

64babe3

fix comments

157386c

add UTs

095f786

fix conflicts

cbc382d

fix linter issue

275b8c6

fix linter issue

4ad60ee

fix UT

ed152f1

Merge branch 'master' of https://github.com/Azure/azure-container-net…

ebaf20e

…working into dualstack-overlay-cni

ashvindeodhar requested changes Apr 20, 2023

View reviewed changes

ashvindeodhar reviewed Apr 20, 2023

View reviewed changes

fix comments

0e9828a

tamilmani1989 requested changes Apr 20, 2023

View reviewed changes

paulyufan2 added 7 commits April 20, 2023 17:26

comments fix

e6a579f

fix comments

159a0da

add fixes for comments

a81a42a

Merge branch 'master' of https://github.com/Azure/azure-container-net…

1290ef2

…working into dualstack-overlay-cni

fix UT

cb0c309

Merge branch 'master' of https://github.com/Azure/azure-container-net…

f4a9058

…working into dualstack-overlay-cni

fix a bug

3bb1d93

paulyufan2 mentioned this pull request Apr 21, 2023

Dualstack overlay cni #1925

Merged

rjdenney closed this Apr 24, 2023


		setNetworkOptions(ipamAddResult.ncResponse, &nwInfo)

		addNatIPV6SubnetInfo(ipamAddConfig.nwCfg, ipamAddResult.ipv6Result, &nwInfo)

Dualstack Overlay CNI #1866

Dualstack Overlay CNI #1866

Uh oh!

Conversation

rjdenney commented Mar 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vipul-21 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paulyufan2 Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

rjdenney commented Mar 21, 2023 •

edited

Loading

paulyufan2 Apr 18, 2023 •

edited

Loading