Skip to content

Conversation

@ZetaoZhuang
Copy link
Contributor

Reason for Change:

Issue Fixed:

Requirements:

Notes:

@ZetaoZhuang ZetaoZhuang requested a review from a team as a code owner April 5, 2023 21:23
@ZetaoZhuang ZetaoZhuang requested review from rbtr and removed request for a team April 5, 2023 21:23
Copy link
Collaborator

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please align with the other String() methods in this file
ex:

func (u UnpublishNetworkContainerResponse) String() string {
// %q as a verb on a byte slice prints safely escaped text instead of individual bytes
return fmt.Sprintf("{Response:%+v UnpublishErrorStr:%s UnpublishStatusCode:%d UnpublishResponseBody:%q}",
u.Response, u.UnpublishErrorStr, u.UnpublishStatusCode, u.UnpublishResponseBody)
}

@ZetaoZhuang ZetaoZhuang requested a review from rbtr April 6, 2023 18:12
@ZetaoZhuang
Copy link
Contributor Author

please align with the other String() methods in this file ex:

func (u UnpublishNetworkContainerResponse) String() string {
// %q as a verb on a byte slice prints safely escaped text instead of individual bytes
return fmt.Sprintf("{Response:%+v UnpublishErrorStr:%s UnpublishStatusCode:%d UnpublishResponseBody:%q}",
u.Response, u.UnpublishErrorStr, u.UnpublishStatusCode, u.UnpublishResponseBody)
}

updated. thanks

@rbtr rbtr enabled auto-merge (squash) April 7, 2023 18:19
@rbtr rbtr merged commit aec0bf9 into master Apr 7, 2023
@rbtr rbtr deleted the fix_delete_nc_log branch April 7, 2023 20:10
@tamilmani1989 tamilmani1989 added the cns Related to CNS. label Apr 13, 2023
@smittal22 smittal22 added the AZR AZR related PR label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AZR AZR related PR cns Related to CNS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants