CNS ipam and client changes to address comments #1913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
previously approved these changes
Apr 12, 2023
Collaborator
rbtr
left a comment
rbtr
left a comment
There was a problem hiding this comment.
needs a lint fixed, otherwise lgtm
rbtr
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adding changes that @rbtr suggested in the last PR for CNS dualstack. Also adds two additional unit tests in case we try removing/adding IPs when only some exist in the IPAM. This results in a unsuccessful request/release with error and puts the IPs back where they originally were.
Issue Fixed:
Requirements:
Notes: