fix CNS client #1920
Merged
fix CNS client #1920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashvindeodhar
approved these changes
Apr 18, 2023
rbtr
reviewed
Apr 19, 2023
Collaborator
rbtr
left a comment
rbtr
left a comment
There was a problem hiding this comment.
@ashvindeodhar/@paulyufan/@ZetaoZhuang
making this an anonymous error is regressive and needs to be addressed in a follow up
| if res.StatusCode == http.StatusNotFound { | ||
| return nil, &CNSClientError{ | ||
| Code: types.UnsupportedAPI, | ||
| Err: errors.Errorf("Unsupported API"), |
Collaborator
There was a problem hiding this comment.
- this error should be a typed error, not an anonymous error, so that it can be compared to with
errors.Is/As - error strings should not be sentence-case ("unsupported API") because they are embedded within other strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR is to fix:
(1) Replace ErrAPINotFound with UnsupportedAPI
(2) check err for client do()