Skip to content

ci: [NPM] improve scale pipeline & fix edge case in scale script #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jun 9, 2023
Merged

ci: [NPM] improve scale pipeline & fix edge case in scale script #1975

merged 24 commits into from
Jun 9, 2023

Conversation

@huntergregory
Copy link
Contributor

@huntergregory huntergregory commented May 23, 2023 •
edited
Loading

Reason for Change:
Improvements to scale pipeline. Also, fix bug in scale script when using zero-values for parameters.

Issue Fixed:

Requirements:

Notes:
Scale Pipeline Improvements:

  1. Fix failures (cleanup RG & getting NPM logs).
  2. Ability to turn on Linux Scale test (but leave Linux off for now).

@huntergregory huntergregory added npm Related to NPM. ci Infra or tooling. linux labels May 23, 2023
@huntergregory huntergregory requested review from matmerr and vakalapa May 23, 2023 17:24
@huntergregory huntergregory force-pushed the hgregory/05-23-linux-scale branch from b342c1b to eff43c5 Compare June 2, 2023 02:19
@huntergregory huntergregory marked this pull request as ready for review June 2, 2023 22:49
@huntergregory huntergregory requested a review from a team as a code owner June 2, 2023 22:49
@huntergregory huntergregory changed the title ci: [NPM] enable Linux in Scale Test Pipeline ci: [NPM] fix Scale Pipeline cleanup & scale script edge case Jun 7, 2023
@huntergregory
Copy link
Contributor Author

huntergregory commented Jun 8, 2023

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 8, 2023

Azure Pipelines successfully started running 3 pipeline(s), but failed to run 2 pipeline(s).

@huntergregory huntergregory changed the title ci: [NPM] fix Scale Pipeline cleanup & scale script edge case ci: [NPM] cleanup scale pipeline & fix edge case in scale script Jun 8, 2023
@huntergregory huntergregory force-pushed the hgregory/05-23-linux-scale branch from 17c04d3 to b73781c Compare June 8, 2023 21:52
@huntergregory huntergregory changed the title ci: [NPM] cleanup scale pipeline & fix edge case in scale script ci: [NPM] improve scale pipeline & fix edge case in scale script Jun 8, 2023
@vakalapa vakalapa merged commit 940a7a7 into master Jun 9, 2023
@vakalapa vakalapa deleted the hgregory/05-23-linux-scale branch June 9, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vakalapa vakalapa vakalapa approved these changes

@matmerr matmerr Awaiting requested review from matmerr

Assignees

No one assigned

Labels

ci Infra or tooling. linux npm Related to NPM.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huntergregory @vakalapa