Remove redundant routes in dualstackoverlay for windows nodes #2002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@princepereira could you review as well please? Thanks! Maybe mention the tests you did with this version of CNI |
paulyufan2
force-pushed
the
paujohns/remove-redundant-route-overlay
branch
from
051c56f to
2e7b5ad
Compare
pjohnst5
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing a redundant route added to Windows VMs for dualstackoverlay
Redundant route being removed:
netsh interface ipv4 add route "<overlay-subnet-prefix>" "<interface-name>" "<overlay-subnet-gateway>"Example:
netsh interface ipv4 add route "10.244.0.0/16" "vEthernet (Ethernet 2)" "10.244.0.1"This route is redundant, because prior to it being added, there is another route added with the same matching-prefix:
Route being added before redundant route:
netsh interface ipv4 add route "10.244.0.0/16" "vEthernet (Ethernet 2)" "0.0.0.0"So the second route is rendered useless, and we don't need it
This was confirmed by @princepereira, so removing the redundant route (both for IPV4 and IPV6)