update: add pod info to windows endpoint #2040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaer-tsun
approved these changes
Jul 5, 2023
Contributor
jaer-tsun
left a comment
jaer-tsun
left a comment
There was a problem hiding this comment.
nice we were just talking about this, lgtm
vakalapa
approved these changes
Jul 5, 2023
paulyufan2
pushed a commit
that referenced
this pull request
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Kappie HNS plugin for windows provides metrics for endpoints, but lacks pod info for the metrics. Adding these here will help us map endpoints to pods.
Linux endpoints currently set these properties, but windows is currently not set.
Requirements:
Notes:
I have tested this by copying the binary to a windows node and restarting a pod. The new properties show up. I have also replaced the new cni binary with the live version to ensure that there were no errors in the logs.