chore: Removing CNI logs that are not useful #2065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vipul-21
reviewed
Jul 19, 2023
| } | ||
|
|
||
| log.Printf("[net] Restored state") | ||
| for _, extIf := range nm.ExternalInterfaces { |
Contributor
There was a problem hiding this comment.
Why do we need to remove this part ? Is this not used anymore?
My understanding is that number of endpoints after restoring the state is displayed in the logs.
Member
Author
There was a problem hiding this comment.
moved to a place where we create and delete endpoints.. this is causing spam for windows mulitenancy case where customer create network per vlan id and this log getting looped for all networks each time on add/del
camrynl
approved these changes
Jul 19, 2023
tamilmani1989
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Removing logs that are not useful and spamming the log file. Also it accounts for cni execution time.
Issue Fixed:
Requirements:
Notes: