test: create nginx deployments in scale test #2074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntergregory
suggested changes
Jul 25, 2023
Contributor
huntergregory
left a comment
huntergregory
left a comment
There was a problem hiding this comment.
looks good! Had some q's about the label script. Sorry to comment later on it
huntergregory
approved these changes
Jul 25, 2023
camrynl
force-pushed
the
camrynl/scalenginx
branch
from
c758474 to
4ff9551
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adapting the NPM scale test to use for future Cilium scale pipeline. Creating a secondary deployment template for nginx, this deployment is an optional parameter. Cilium will use the nginx deployment for throughput testing.
Issue Fixed:
Requirements:
Notes: