refactor: Match CNI go tests #2092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulyufan2
reviewed
Jul 28, 2023
jpayne3506
force-pushed
the
jpayne3506/gowinrefactor
branch
from
7e6699d to
bcd100a
Compare
vipul-21
reviewed
Jul 28, 2023
| restConfig := k8sutils.MustGetRestConfig(t) | ||
|
|
||
| t.Log("Create Clientset") | ||
| clientset, _ := k8sutils.MustGetClientset() |
Contributor
There was a problem hiding this comment.
Why are we ignoring the error ?
Contributor
Author
There was a problem hiding this comment.
Good question! Going to change this.
| } | ||
| if len(pods.Items) <= 1 { | ||
| require.NoError(t, errors.New("Less than 2 pods on node")) | ||
| t.Fatal("Less than 2 pods on node") |
Contributor
There was a problem hiding this comment.
Good to have node name as well ?
jpayne3506
force-pushed
the
jpayne3506/gowinrefactor
branch
5 times, most recently
from
980f99c to
34fcb70
Compare
vipul-21
approved these changes
Jul 28, 2023
jpayne3506
force-pushed
the
jpayne3506/gowinrefactor
branch
from
34fcb70 to
48a7a66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Did not match the design of other go tests, slowing down development.
Issue Fixed:
Requirements:
Notes: