[CNI] Migrate zap logger for acn ipam package #2299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulyufan2
changed the title
behzad-mir
requested changes
Oct 17, 2023
paulyufan2
force-pushed
the
acnipamzaplogger
branch
3 times, most recently
from
22e14a7 to
35154f1
Compare
paulyufan2
force-pushed
the
acnipamzaplogger
branch
2 times, most recently
from
e24f958 to
8dbd2a7
Compare
paulyufan2
force-pushed
the
acnipamzaplogger
branch
from
bda636a to
6aba4bf
Compare
vipul-21
requested changes
Oct 27, 2023
ipam/azure.go
Outdated
| httpClient := common.InitHttpClient(httpConnectionTimeout, responseHeaderTimeout) | ||
| if httpClient == nil { | ||
| log.Errorf("[ipam] Failed intializing http client") | ||
| logger.Info("Failed intializing http client") |
ipam/azure.go
Outdated
|
|
||
| if resp.StatusCode != http.StatusOK { | ||
| log.Errorf("[ipam] http return error code for wireserver call %+v", resp) | ||
| logger.Info("http return error code for wireserver call", zap.Any("response", resp)) |
vipul-21
approved these changes
Oct 27, 2023
behzad-mir
approved these changes
Oct 27, 2023
paulyufan2
force-pushed
the
acnipamzaplogger
branch
from
10b8473 to
91f9270
Compare
paulyufan2
force-pushed
the
acnipamzaplogger
branch
from
91f9270 to
c8f415d
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR is to migrate zap logger for ACN ipam package
Issue Fixed:
Requirements:
Notes: