ci: Move E2E runtime variables from job level to stage #2305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpayne3506
changed the title
nddq
force-pushed
the
jpayne3506/patch2
branch
from
a68c83a to
de212c6
Compare
vipul-21
reviewed
Oct 27, 2023
| TAG: $[ stagedependencies.setup.env.outputs['EnvironmentalVariables.Tag'] ] | ||
| CURRENT_VERSION: $[ stagedependencies.containerize.check_tag.outputs['CurrentTagManifests.currentTagManifests'] ] | ||
| commitID: $[ stagedependencies.setup.env.outputs['EnvironmentalVariables.commitID'] ] | ||
| GOPATH: "$(Agent.TempDirectory)/go" # Go workspace path |
Contributor
There was a problem hiding this comment.
I agree that commit id was shared with other stages that is why it is job level variable. Are all the other variables also need in other stages ?
Contributor
Author
There was a problem hiding this comment.
This change makes it where the variables are visible to all jobs in their respective stage. They do not get passed into other stages.
Contributor
There was a problem hiding this comment.
Understood, so the variables are visible or accessible to other jobs in the same stage. We are just not using those in those jobs.
vipul-21
approved these changes
Oct 27, 2023
rbtr
approved these changes
Oct 31, 2023
jpayne3506
force-pushed
the
jpayne3506/patch2
branch
from
de212c6 to
6a825c9
Compare
matmerr
pushed a commit
that referenced
this pull request
Jan 17, 2024
ci: Move E2E runtime variables to stage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
E2E did not have consistent assigning of variables. This led to a bug that affected cilium overlay E2E logging because the commitID variable was never passed to the failure logs. This was not showing as a passed run would skip the logging job.
Issue Fixed:
Requirements:
Notes: