fix: cni should not invoke cns to release ips for muiltitenancy #2357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if err != nil { | ||
| plugin.cleanupAllocationOnError(ipamAddResult.defaultInterfaceInfo.ipResult, nwCfg, args, options) | ||
| // for multi-tenancies scenario, CNI is not supposed to invoke CNS for cleaning Ips | ||
| if !(nwCfg.MultiTenancy && nwCfg.IPAM.Type == network.AzureCNS) { |
rbtr
added
release/1.4
rbtr
force-pushed
the
fix_cni_ip_cleanup
branch
from
5289f1f to
1c4259c
Compare
rbtr
force-pushed
the
fix_cni_ip_cleanup
branch
from
1c4259c to
7491932
Compare
tamilmani1989
approved these changes
Nov 8, 2023
Member
tamilmani1989
left a comment
tamilmani1989
left a comment
There was a problem hiding this comment.
@ZetaoZhuang can you add UT in separate PR?
rbtr
approved these changes
Nov 8, 2023
Contributor
Author
Sure. I have those already in my local branch |
4 tasks
matmerr
pushed a commit
that referenced
this pull request
Jan 17, 2024
cni should not invoke cns to release ips for muiltitenancy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
cni should not invoke cns to release ips for muiltitenancy
Issue Fixed:
Requirements:
Notes: