Skip to content

Conversation

@jpayne3506
Copy link
Contributor

@jpayne3506 jpayne3506 commented Nov 9, 2023

Reason for Change:

Priority update to hcsshim and dependencies as dependabot has a backlog.

Issue Fixed:

Requirements:

Notes:

@jpayne3506 jpayne3506 added the ci Infra or tooling. label Nov 9, 2023
@jpayne3506 jpayne3506 self-assigned this Nov 9, 2023
@jpayne3506 jpayne3506 requested a review from a team as a code owner November 9, 2023 03:30
@jpayne3506 jpayne3506 changed the title chore: Update hcsshim chore: Update hcsshim v0.11.4 Nov 9, 2023
@rbtr
Copy link
Collaborator

rbtr commented Nov 9, 2023

I don't think we need to do this, as we're not actually using upstream hcsshim, we're using @vakalapa's fork

github.com/Microsoft/hcsshim => github.com/vakalapa/hcsshim v0.9.1-0.20211203205307-837d4d06df77

@vakalapa
Copy link
Contributor

vakalapa commented Nov 9, 2023

@jpayne3506 can you run NPM conformance tests in windows run with this change and see if everything is fine, if yes then we can proceed with this change, or else we will have to rely on using hcsshim from my fork. cc: @huntergregory

@jpayne3506 jpayne3506 force-pushed the jpayne3506/cgrestful branch from 14584a2 to 8d6ea95 Compare November 9, 2023 21:52
@jpayne3506 jpayne3506 enabled auto-merge (squash) November 9, 2023 23:04
@jpayne3506 jpayne3506 merged commit 0e32b3e into master Nov 10, 2023
@jpayne3506 jpayne3506 deleted the jpayne3506/cgrestful branch November 10, 2023 02:02
matmerr pushed a commit that referenced this pull request Jan 17, 2024
* ci: update hcsshim v0.11.4

* ci update containerd v1.7.8

* ci: update go-restful v2.16.0

* ci: update docker/distribution v2.8.3

* ci: update jsonparser v1.1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Infra or tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants