Skip to content

ci: validate async delete #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 14, 2023
Merged

ci: validate async delete #2379

merged 4 commits into from
Nov 14, 2023

Conversation

@camrynl
Copy link
Contributor

@camrynl camrynl commented Nov 10, 2023

Reason for Change:

  • adds a script to validate pod async delete when cns is down
  • only testing in swift for now, will add to cilium stages once azure-ipam changes are reverted back

Issue Fixed:

Requirements:

Notes:

@camrynl camrynl added the ci Infra or tooling. label Nov 10, 2023
@camrynl camrynl marked this pull request as ready for review November 10, 2023 19:17
@camrynl camrynl requested a review from a team as a code owner November 10, 2023 19:17
@camrynl camrynl requested a review from aegal November 10, 2023 19:17
@rbtr rbtr removed the request for review from aegal November 10, 2023 21:13
rbtr
rbtr previously approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty for adding this 👏 lgtm

@rbtr
Copy link
Collaborator

rbtr commented Nov 10, 2023

cc @tyler-lloyd

@camrynl camrynl force-pushed the camrynl/test-async-delete branch from a70c8e2 to 07383d6 Compare November 10, 2023 21:23
jpayne3506
jpayne3506 reviewed Nov 10, 2023
View reviewed changes
jpayne3506
jpayne3506 previously approved these changes Nov 10, 2023
View reviewed changes
@rbtr rbtr force-pushed the camrynl/test-async-delete branch from eefe733 to 84563ea Compare November 11, 2023 00:43
@camrynl camrynl force-pushed the camrynl/test-async-delete branch from dec8788 to 6a6979c Compare November 13, 2023 17:16
@camrynl camrynl enabled auto-merge (squash) November 13, 2023 17:17
@camrynl camrynl merged commit 9330999 into master Nov 14, 2023
@camrynl camrynl deleted the camrynl/test-async-delete branch November 14, 2023 00:22
matmerr pushed a commit that referenced this pull request Jan 17, 2024
@camrynl @matmerr
ci: validate async delete (#2379)
f13a2af 
* test async delete in pipeline

* test in swift stage only

* check cns patch is removed

* fix syntax in patch check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rbtr rbtr rbtr approved these changes

@jpayne3506 jpayne3506 jpayne3506 approved these changes

@tamilmani1989 tamilmani1989 Awaiting requested review from tamilmani1989

@vipul-21 vipul-21 Awaiting requested review from vipul-21

Assignees

No one assigned

Labels

ci Infra or tooling.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@camrynl @rbtr @jpayne3506