Skip to content

chore: Backport VNet Scale Changes into 1.4 release of CNS #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

chore: Backport VNet Scale Changes into 1.4 release of CNS #2414

wants to merge 2 commits into from

Conversation

@nairashu
Copy link
Contributor

@nairashu nairashu commented Nov 27, 2023

Reason for Change:
Backporting a couple of Vnet Scale PRs into the CNS 1.4 release cycle:

Issue Fixed:
N/A

Requirements:

Notes:

nairashu and others added 2 commits November 22, 2023 22:41
@nairashu
[Feature: Vnet Scale]: Added the vnet block mode of operation for the…
85f30e0 
… NC Type in the NNC (#1872)

Added the vnet block mode of operation for the NC Type
@aggarwal0009
[Vnet Scale - CNS]: Flattening CIDR ranges for Node NNC to a list (#1921
9fe4e32 
)

* Read secondary CIDRs from VnetScale NNC

* fix comment

* update comment

* For VnetScale mode, Use 1st IP for def gateway instead of 0th for windows

* fix/add import

* address pr comments

* add comments

* address pr comments

* wrap error

* fix typo

* fix UT
@nairashu nairashu requested a review from a team as a code owner November 27, 2023 18:36
@nairashu nairashu requested a review from neaggarwMS November 27, 2023 18:36
@rbtr rbtr closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neaggarwMS neaggarwMS Awaiting requested review from neaggarwMS neaggarwMS is a code owner automatically assigned from Azure/acn-cns-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nairashu @rbtr @aggarwal0009