Enable CNS swiftv2 path for SF/Standalone scenario to program secondary nics #2444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmurudi
commented
Dec 18, 2023
kmurudi
force-pushed
the
enableSwiftV2_SF_CNSRequestIPs
branch
from
24436b9 to
2dfef9a
Compare
paulyufan2
reviewed
Jan 3, 2024
kmurudi
force-pushed
the
enableSwiftV2_SF_CNSRequestIPs
branch
7 times, most recently
from
64fb75d to
2392a59
Compare
kmurudi
force-pushed
the
enableSwiftV2_SF_CNSRequestIPs
branch
from
53403be to
d0edcb2
Compare
nddq
reviewed
Jan 23, 2024
kmurudi
force-pushed
the
enableSwiftV2_SF_CNSRequestIPs
branch
from
8012c86 to
d8e2e72
Compare
paulyufan2
reviewed
Feb 5, 2024
…test file, removed addInterfaces config field
kmurudi
force-pushed
the
enableSwiftV2_SF_CNSRequestIPs
branch
from
0a2c82e to
c44f71d
Compare
kmurudi
force-pushed
the
enableSwiftV2_SF_CNSRequestIPs
branch
from
6b65be6 to
9038e8d
Compare
kmurudi
force-pushed
the
enableSwiftV2_SF_CNSRequestIPs
branch
4 times, most recently
from
4703fad to
6743aa6
Compare
kmurudi
force-pushed
the
enableSwiftV2_SF_CNSRequestIPs
branch
from
6743aa6 to
b13f1e2
Compare
nddq
reviewed
Feb 8, 2024
…uest passed as a pointer
kmurudi
force-pushed
the
enableSwiftV2_SF_CNSRequestIPs
branch
from
a8d914e to
ebf6640
Compare
nddq
reviewed
Feb 8, 2024
kmurudi
force-pushed
the
enableSwiftV2_SF_CNSRequestIPs
branch
from
7a2b63d to
6513227
Compare
Signed-off-by: Kshitija Murudi <kmurudi@microsoft.com>
kmurudi
force-pushed
the
enableSwiftV2_SF_CNSRequestIPs
branch
from
6bf37d5 to
a0c9666
Compare
nddq
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
L1VH/Singularity & Swiftv2 need to program secondary nics for creating pod via containerd. Changes have been supported for AKS pod scenario, but this PR adds support for windows Service fabric/standalone scenario as it gets the data from DNC goal state.
Issue Fixed:
Requirements:
Notes: