fix: block pod to wireserver port 80 traffic on windows multitenancy #2515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamilmani1989
approved these changes
Jan 22, 2024
Member
|
@QxBytes can you also get approval from @ashvindeodhar |
Contributor
|
Curious to know why this is only a problem in windows multitenancy and not others? |
Contributor
Author
Addressed this in linux multitenancy here (#2395) |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Traffic from the pod to the wireserver on port 80 should not leave the VM.
Issue Fixed:
See above.
Requirements:
Notes:
Tested Windows Container on Windows 2022. After rule is added, wgets from the pod to websites such as google.com are still seen leaving the pod destined towards the 12:34... MAC. After the rule is added, traffic is still detected when pinging other pods (confirming the rule does not block pod-pod traffic). Tested routing wireserver requests to the eth0 and apipa eth inside the pod and confirmed that for hyper-v isolation containers, the vfp filter counter increases when requests to the wireserver are made (no traffic on the node is detected going to the wireserver from the pod either). Without the rule, traffic is detected on the node from the pod to the wireserver.