Adding PortMapping support to Azure cni for Windows. #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@erfrimod Thanks for contributing! Will there be anything else except for PortMappings in RuntimeConfig? |
Contributor
Author
|
@saiyan86 I just updated with further changes so that the RuntimeConfig portmappings are converted into Endpoing policy objects and sent to HNS. |
Contributor
Contributor
|
/lgtm |
Contributor
@madhanrm portmap plugin handles this for linux. please take a look at conflist file. Let me know if I misunderstood your comment. |
|
/lgtm |
sharmasushant
changed the title
Contributor
|
@erfrimod Could you please resolve the conflicts so we can merge this PR? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure CNI doesn’t program any port mappings. Its not supported in Azure CNI.
Earlier it worked because the port mapping was programmed through NAT network which was added by accident.
WINCNI does support it and here is the code that does it...