Remove HNSNetwork's DNS suffix in Windows #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharmasushant
suggested changes
Oct 10, 2018
Contributor
sharmasushant
left a comment
sharmasushant
left a comment
There was a problem hiding this comment.
Let's do a regression run for Linux as well.
Contributor
Author
|
@sharmasushant Linux testing passed. |
sharmasushant
approved these changes
Oct 10, 2018
|
This looks great, thanks Yongli! |
sharmasushant
pushed a commit
to sharmasushant/azure-container-networking
that referenced
this pull request
Oct 24, 2018
* remove network dns suffix and preserve endpoint dns suffix
sharmasushant
pushed a commit
to sharmasushant/azure-container-networking
that referenced
this pull request
Oct 24, 2018
* remove network dns suffix and preserve endpoint dns suffix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR removes HNSNetwork's DNS suffix in Windows. Previously, the HNSNetwork's DNS suffix gets overwritten by newly created HNSEndpoint's DNS suffix.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #245