fix: fixing CNS IP releae for azure CNI in case of managed endpoint s… #2588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzad-mir
requested review from
ashvindeodhar,
jpayne3506,
rbtr and
tamilmani1989
behzad-mir
force-pushed
the
behzad-cns-iprelease-fix
branch
2 times, most recently
from
391d3df to
a0c70d5
Compare
tamilmani1989
previously approved these changes
Feb 15, 2024
behzad-mir
force-pushed
the
behzad-cns-iprelease-fix
branch
from
a0c70d5 to
509f8db
Compare
rbtr
reviewed
Feb 15, 2024
behzad-mir
force-pushed
the
behzad-cns-iprelease-fix
branch
from
509f8db to
13c2560
Compare
nddq
approved these changes
Feb 16, 2024
jpayne3506
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Fixed:
CNS is using [first 8 digit of containerID]-eth0 format to release IPs for azure CNI. However, when CNS Manage endpoint state is enable it should also use the full containerID as the key.
Requirements:
Notes: