Skip to content

Conversation

@ZetaoZhuang
Copy link
Contributor

@ZetaoZhuang ZetaoZhuang commented Feb 23, 2024

Reason for Change:
Remove EnableAZR config flag from CNS, the config flag is unnecessary.

Issue Fixed:

Requirements:

Notes:

@ZetaoZhuang ZetaoZhuang requested a review from a team as a code owner February 23, 2024 02:45
@ashvindeodhar
Copy link
Member

In the PR description please indicate that the change is to remove the config flag from CNS. The config flag is unnecessary

ashvindeodhar
ashvindeodhar previously approved these changes Feb 23, 2024
@ZetaoZhuang ZetaoZhuang requested a review from rbtr February 23, 2024 22:21
@rbtr rbtr requested a review from ashvindeodhar February 23, 2024 22:36
@rbtr
Copy link
Collaborator

rbtr commented Feb 23, 2024

lgtm but want a review from @ashvindeodhar since it's changed a bit since the approval

Copy link
Member

@ashvindeodhar ashvindeodhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @rbtr for reviewing these changes!

@ZetaoZhuang
Copy link
Contributor Author

lgtm but want a review from @ashvindeodhar since it's changed a bit since the approval

Thanks @rbtr. can you approve to lift the change requested? 👍

@ZetaoZhuang ZetaoZhuang added this pull request to the merge queue Feb 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 24, 2024
@ZetaoZhuang ZetaoZhuang added this pull request to the merge queue Feb 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 24, 2024
@ZetaoZhuang ZetaoZhuang added this pull request to the merge queue Feb 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2024
@ZetaoZhuang ZetaoZhuang added this pull request to the merge queue Feb 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2024
@ZetaoZhuang ZetaoZhuang added this pull request to the merge queue Feb 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 28, 2024
@ZetaoZhuang ZetaoZhuang added this pull request to the merge queue Feb 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 28, 2024
@ZetaoZhuang ZetaoZhuang added this pull request to the merge queue Feb 28, 2024
Merged via the queue into master with commit 2ddfde9 Feb 29, 2024
@ZetaoZhuang ZetaoZhuang deleted the remove_azrEnabled_from_cns branch February 29, 2024 02:32
@smittal22 smittal22 added the AZR AZR related PR label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AZR AZR related PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants