Skip to content

Conversation

@QxBytes
Copy link
Contributor

@QxBytes QxBytes commented Mar 11, 2024

Reason for Change:

In preparation for uploading logs, this PR removes logs which do not add significant additional information. Often, this means they log something that has already been logged, or that one could reasonably infer execution based on the presence/absence of an error.

Issue Fixed:

See above.

Requirements:

Notes:

@QxBytes QxBytes added the cni Related to CNI. label Mar 11, 2024
@QxBytes QxBytes marked this pull request as ready for review March 12, 2024 23:29
@QxBytes QxBytes requested review from a team as code owners March 12, 2024 23:29
@QxBytes QxBytes requested a review from jpayne3506 March 12, 2024 23:29
Copy link
Contributor

@jpayne3506 jpayne3506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @paulyufan2 what do you think?

@jpayne3506 jpayne3506 enabled auto-merge March 15, 2024 19:11
@QxBytes
Copy link
Contributor Author

QxBytes commented Mar 19, 2024

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jpayne3506 jpayne3506 added this pull request to the merge queue Mar 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 19, 2024
@QxBytes QxBytes added this pull request to the merge queue Mar 20, 2024
Merged via the queue into master with commit 6c6c4a4 Mar 21, 2024
@QxBytes QxBytes deleted the alew/clean-logs branch March 21, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cni Related to CNI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants