CNI to support transparent mode #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…working into calico_change # Conflicts: # cni/netconfig.go # netlink/link.go # netlink/netlink_test.go # network/endpoint_linux.go
sharmasushant
suggested changes
Dec 21, 2018
cni/network/network.go
Outdated
| // (network name, container id, name of the interface inside the container) | ||
| vethName := fmt.Sprintf("%s%s%s", networkId, k8sContainerID, k8sIfName) | ||
| if nwCfg.Mode == opModeCalico { | ||
| vethName = fmt.Sprintf("%s.%s", k8sNamespace, k8sPodName) |
Contributor
There was a problem hiding this comment.
lets note here that this mechanism of using only namespace and name is not unique for different incarnations of POD/container. IT will result in unpredictable behavior if API server decides to reorder DELETE and ADD call for new incarnation of same POD.
network/endpoint_linux.go
Outdated
| // Prefix for host virtual network interface names. | ||
| hostVEthInterfacePrefix = commonInterfacePrefix + "v" | ||
|
|
||
| transPrefix = "cali" |
Contributor
There was a problem hiding this comment.
Add a commen tto indicate this is prefix in transparent mode
network/endpoint_linux.go
Outdated
| nlRoute := &netlink.Route{ | ||
| Family: netlink.GetIpAddressFamily(route.Gw), | ||
| Dst: &route.Dst, | ||
| Src: route.Src, |
Contributor
There was a problem hiding this comment.
lets ensure that multitenancy works with this change.
Member
Author
There was a problem hiding this comment.
we dint change anything here.. i can remove this also. we are not setting source anywhere
network/endpoint_linux.go
Outdated
| nlRoute := &netlink.Route{ | ||
| Family: netlink.GetIpAddressFamily(route.Gw), | ||
| Dst: &route.Dst, | ||
| Src: route.Src, |
Contributor
There was a problem hiding this comment.
ensure that we can delete successfully for multitenancy
tamilmani1989
changed the title
sharmasushant
approved these changes
Jan 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for azure cni to support calico policies in Azure VMs
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: