Skip to content

Honoring xtables lock #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 20, 2019
Merged

Honoring xtables lock #315

merged 17 commits into from
Mar 20, 2019

Conversation

@saiyan86
Copy link
Contributor

@saiyan86 saiyan86 commented Mar 19, 2019 •
edited
Loading

What this PR does / why we need it:

This PR

  1. making Azure-NPM honors xtables lock for all operations.
  2. fixes a bug in egress network policy control.
  3. disables Azure-NPM telemetry for now to avoid throttling wireserver.

Which issue this PR fixes : fixes #252 , fixes #269

@saiyan86 saiyan86 changed the title Update npm Honoring xtables lock Mar 19, 2019
@saiyan86 saiyan86 requested a review from serbrech March 19, 2019 03:33
@saiyan86 saiyan86 self-assigned this Mar 19, 2019
@saiyan86 saiyan86 mentioned this pull request Mar 19, 2019
Merged
4 tasks
serbrech
serbrech previously approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@serbrech serbrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This was referenced Mar 19, 2019
Closed
Closed
@saiyan86 saiyan86 merged commit 97d3ddc into Azure:master Mar 20, 2019
@saiyan86 saiyan86 deleted the updateNPM branch March 20, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashvindeodhar ashvindeodhar ashvindeodhar approved these changes

@tamilmani1989 tamilmani1989 Awaiting requested review from tamilmani1989

@jaer-tsun jaer-tsun Awaiting requested review from jaer-tsun

@ninzavivek ninzavivek Awaiting requested review from ninzavivek

+1 more reviewer

@serbrech serbrech serbrech left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@saiyan86 saiyan86

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

iptables commands should wait on xtables lock

3 participants

@saiyan86 @serbrech @ashvindeodhar