Skip HotAttachEp from CNM createEndpoint #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
==========================================
+ Coverage 45.16% 45.18% +0.01%
==========================================
Files 25 25
Lines 3538 3539 +1
==========================================
+ Hits 1598 1599 +1
Misses 1685 1685
Partials 255 255
Continue to review full report at Codecov.
|
ninzavivek
previously approved these changes
Apr 12, 2019
Contributor
ninzavivek
left a comment
ninzavivek
left a comment
There was a problem hiding this comment.
Approved with suggestions.
Member
|
Sweet, this looks like this is working on CNM. |
ninzavivek
approved these changes
Apr 12, 2019
This was referenced Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNM attaches endpoint separately as a part of Join request. This
change avoids the hot attach endpoint operation from CNM create
endpoint. CNI still performs hot attach endpoint as a part of create
endpoint.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: