Delete container even if NetNs is not specified #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #357 +/- ##
=======================================
Coverage 40.93% 40.93%
=======================================
Files 25 25
Lines 3518 3518
=======================================
Hits 1440 1440
Misses 1870 1870
Partials 208 208Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #357 +/- ##
=======================================
Coverage 40.93% 40.93%
=======================================
Files 25 25
Lines 3518 3518
=======================================
Hits 1440 1440
Misses 1870 1870
Partials 208 208Continue to review full report at Codecov.
|
tamilmani1989
approved these changes
May 9, 2019
Member
tamilmani1989
left a comment
tamilmani1989
left a comment
There was a problem hiding this comment.
lgtm. let sushant also review this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetNs is an optional argument for deleting the network container.
If not specified, CNI logs the error and proceeds with deleting the
network container. In case of windows multitenancy, pod name
and pod namespace are required and it will return an appropriate
error.