Add pid to log #360
Merged
Add pid to log #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
==========================================
- Coverage 40.93% 40.86% -0.07%
==========================================
Files 25 25
Lines 3518 3519 +1
==========================================
- Hits 1440 1438 -2
- Misses 1870 1872 +2
- Partials 208 209 +1
Continue to review full report at Codecov.
|
Contributor
Author
|
@sharmasushant |
saiyan86
suggested changes
May 13, 2019
Contributor
Author
|
@saiyan86 |
saiyan86
approved these changes
May 21, 2019
Contributor
|
/lgtm |
tamilmani1989
requested changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Each cni request starts a new process, but they share same log file. When multi cni requests received at same time, it is difficult to distinguish logs for each request, add pid to logs will help to better troubleshooting issue.
Which issue this PR fixes
Fixes #354